Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 28, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Previously, the value for S or R that was set may not have been used, so the information is lost. If one of the values has been set, this method of initialization should be preferred over the force of infection method. This is done by changing the order of the initialization methods.
  • The check if all of the compartments are >0 is more appropriate after the initialization, so the location is changed (from check_constraints function to the initialization method).

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #958.

@lenaploetzke lenaploetzke added the status::in progress This issue is in progess. label Feb 28, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 28, 2024
@lenaploetzke lenaploetzke linked an issue Feb 28, 2024 that may be closed by this pull request
2 tasks
…ent-a-check-for-the-results-of-the-initialization
@codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (c484b89) to head (ad239f4).
Report is 7 commits behind head on main.

❗ Current head ad239f4 differs from pull request most recent head 3ce59a1. Consider uploading reports for the commit 3ce59a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   96.22%   96.29%   +0.07%     
==========================================
  Files         124      124              
  Lines        9699     9699              
==========================================
+ Hits         9333     9340       +7     
+ Misses        366      359       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke added status::in review This issues is in review. model::ide This issue concerns any kind of integro differential equations-based model. and removed status::in progress This issue is in progess. labels Feb 28, 2024
@lenaploetzke lenaploetzke requested review from mknaranja and removed request for annawendler March 20, 2024 12:36
Copy link
Member

@mknaranja mknaranja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenaploetzke Thanks for the changes. I only have some minor suggestions.

Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from mknaranja March 22, 2024 11:17
@mknaranja mknaranja merged commit ce75c58 into main Mar 22, 2024
@mknaranja mknaranja deleted the 958-implement-a-check-for-the-results-of-the-initialization branch March 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model::ide This issue concerns any kind of integro differential equations-based model. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a check for the results of the initialization

3 participants