-
Notifications
You must be signed in to change notification settings - Fork 19
953 Implement basic stochastic equation based model #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New stochastic Versions of advance and simulate Started implementing an Euler Maruyama Core
expose some members of FlowSimulation for derived classes, update simulate(_flows) doc comments.
…_flows_stochastic) in a new simulation.h header in the model directory. other small fixes and formatting
|
I double checked for dangling references. Apparently, gcc 11 and clang 17 either do not care, or more probably fix them silently (dangling references cause undefined behaviour, so the compiler is technically allowed to do anything). However, gcc 13 does complain, and in both |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
==========================================
- Coverage 96.36% 96.33% -0.03%
==========================================
Files 123 129 +6
Lines 9844 10047 +203
==========================================
+ Hits 9486 9679 +193
- Misses 358 368 +10 ☔ View full report in Codecov by Sentry. |
mknaranja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
mknaranja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reneSchm Thanks for the review. With the last minor changes we can then merge :)
this only matters for SDE models, as they use dt in the DerivFunction.
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #953