Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 22, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Changed the initial transitions so that when using a smaller step size, the resulting number of people in a compartment is no longer negative.
  • small corrections of the comments

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #947.

@lenaploetzke lenaploetzke added the model::ide This issue concerns any kind of integro differential equations-based model. label Feb 22, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 22, 2024
@lenaploetzke lenaploetzke linked an issue Feb 22, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke added the status::in review This issues is in review. label Feb 22, 2024
@codecov
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (105816d) to head (6e72497).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   96.22%   96.33%   +0.11%     
==========================================
  Files         124      129       +5     
  Lines        9699    10047     +348     
==========================================
+ Hits         9333     9679     +346     
- Misses        366      368       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke requested review from HenrZu and removed request for annawendler March 20, 2024 12:37
Co-authored-by: Henrik Zunker <henrik.zunker@dlr.de>
@lenaploetzke lenaploetzke requested a review from HenrZu April 2, 2024 08:26
@HenrZu HenrZu merged commit 4886fcf into main Apr 2, 2024
@HenrZu HenrZu deleted the 947-example-for-ide-secir-model-not-working-as-expected branch April 2, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model::ide This issue concerns any kind of integro differential equations-based model. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example for IDE-SECIR model not working as expected

3 participants