Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 5, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • added ConfirmedCasesNoAgeEntry to epi_data
  • added method to use real data for an initialization of the lct model - method is comparable to the initialization of the ODE model, see also the master thesis

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #893

@lenaploetzke lenaploetzke added class::feature A feature to be implemented for some part of the software prio::moderate The priority of this task is moderate. status::in progress This issue is in progess. loc::infrastructure General MEmilio Infrastructure related issues model::lct Models using the linear chain trick labels Feb 5, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 5, 2024
@lenaploetzke lenaploetzke linked an issue Feb 5, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke added status::in review This issues is in review. and removed status::in progress This issue is in progess. labels Feb 13, 2024
@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (f005eaf) to head (7b1b461).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   96.21%   96.29%   +0.07%     
==========================================
  Files         122      123       +1     
  Lines        9638     9844     +206     
==========================================
+ Hits         9273     9479     +206     
  Misses        365      365              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I haven't looked at the actual computation and the tests so far and will do this soon.

@lenaploetzke
Copy link
Member Author

I have to restructure the file parameters_io.h because of the extensive changes of the LCT model in the main branch. The functionality will remain the same.

lenaploetzke and others added 3 commits March 6, 2024 16:23
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from annawendler March 7, 2024 11:03
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the review.

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I wouldn't add an example right now but discuss this in #897 as suggested by you.

@annawendler annawendler merged commit 3fb02ec into main Mar 20, 2024
@annawendler annawendler deleted the 893-add-initialization-method-with-real-data-for-lct-model branch March 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software loc::infrastructure General MEmilio Infrastructure related issues model::lct Models using the linear chain trick prio::moderate The priority of this task is moderate. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add initialization method with real data for LCT model

3 participants