-
Notifications
You must be signed in to change notification settings - Fork 19
893 add initialization method with real data for lct model #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
893 add initialization method with real data for lct model #920
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 96.21% 96.29% +0.07%
==========================================
Files 122 123 +1
Lines 9638 9844 +206
==========================================
+ Hits 9273 9479 +206
Misses 365 365 ☔ View full report in Codecov by Sentry. |
annawendler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I haven't looked at the actual computation and the tests so far and will do this soon.
|
I have to restructure the file parameters_io.h because of the extensive changes of the LCT model in the main branch. The functionality will remain the same. |
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
annawendler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished the review.
annawendler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I wouldn't add an example right now but discuss this in #897 as suggested by you.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #893