Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 5, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • added new model parameter m_tol to IDE-SECIR model (see related issue for reasons)

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #918

@lenaploetzke lenaploetzke added status::in progress This issue is in progess. model::ide This issue concerns any kind of integro differential equations-based model. class::improvement Cleanup that doesn't affect functionality loc::infrastructure General MEmilio Infrastructure related issues labels Feb 5, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 5, 2024
@lenaploetzke lenaploetzke linked an issue Feb 5, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke added status::in review This issues is in review. and removed status::in progress This issue is in progess. labels Feb 5, 2024
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@annawendler annawendler merged commit b0363c4 into main Feb 8, 2024
@annawendler annawendler deleted the 918-add-function-to-change-the-tolerance-in-ide-model branch February 8, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality loc::infrastructure General MEmilio Infrastructure related issues model::ide This issue concerns any kind of integro differential equations-based model. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add function to change the tolerance in IDE model

3 participants