Skip to content

Conversation

@johapau
Copy link
Collaborator

@johapau johapau commented Jan 29, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Integration of age groups into the easier models
  • Examples demonstrating the usage

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@johapau johapau linked an issue Jan 29, 2024 that may be closed by this pull request
2 tasks
@johapau johapau added class::feature A feature to be implemented for some part of the software prio::moderate The priority of this task is moderate. loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. labels Jan 29, 2024
@johapau johapau self-assigned this Jan 29, 2024
@johapau johapau requested a review from HenrZu January 29, 2024 09:29
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Good work 👍
We should test all examples and check if the results are still equal to the former version. I would recommend to use the print_table function from the time series class. Then you can simply write the ostream to a txt file and then compare :)
Also, a new example ode_seir_ageres.cpp would probably be nice

@codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (a245aee) to head (4e874c9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   96.34%   96.41%   +0.06%     
==========================================
  Files         129      130       +1     
  Lines       10072    10265     +193     
==========================================
+ Hits         9704     9897     +193     
  Misses        368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu requested a review from jubicker April 4, 2024 13:08
@HenrZu HenrZu requested a review from jubicker April 25, 2024 08:22
HenrZu and others added 2 commits April 29, 2024 15:59
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
@HenrZu HenrZu requested a review from jubicker April 30, 2024 05:58
@HenrZu HenrZu changed the title 905 add age group reolution to seir and sir model 905 add age group resolution to seir and sir model Apr 30, 2024
@HenrZu HenrZu merged commit f0191b6 into main May 2, 2024
@HenrZu HenrZu deleted the 905-add-age-group-reolution-to-seir-and-sir-model branch May 2, 2024 08:42
reneSchm pushed a commit that referenced this pull request May 24, 2024
- Integration of age groups into the seir and sir models
- New examples using the age groups

Co-authored-by: HenrZu <69154294+HenrZu@users.noreply.github.com>
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::moderate The priority of this task is moderate.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add age-group reolution to SEIR and SIR Model

4 participants