Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Jan 18, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • implement bindings for SECIRVVS model
  • includes basic model, ageres, graphmodel, io functions and parameter studies
  • example to explain usage in python

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Closes #300

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@MaxBetzDLR MaxBetzDLR linked an issue Jan 18, 2024 that may be closed by this pull request
@MaxBetzDLR MaxBetzDLR marked this pull request as ready for review March 7, 2024 13:03
@codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (8ddb863) to head (fa0f7b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10056    10056           
=======================================
  Hits         9688     9688           
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBetzDLR MaxBetzDLR requested a review from HenrZu March 28, 2024 09:12
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Only some comments .

HenrZu
HenrZu previously approved these changes Apr 4, 2024
@HenrZu HenrZu dismissed their stale review April 4, 2024 11:48

visual bug

@MaxBetzDLR MaxBetzDLR merged commit f59d955 into main Apr 4, 2024
@MaxBetzDLR MaxBetzDLR deleted the 300-python-bindings-for-new-vaccination-model branch April 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python bindings for new vaccination model

3 participants