-
Notifications
You must be signed in to change notification settings - Fork 19
888 Make Apply_variant function more generic and fix issue with default value #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
888 Make Apply_variant function more generic and fix issue with default value #904
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
+ Coverage 95.60% 95.88% +0.27%
==========================================
Files 118 118
Lines 9448 9397 -51
==========================================
- Hits 9033 9010 -23
+ Misses 415 387 -28 ☔ View full report in Codecov by Sentry. |
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I'd like to see a few more changes.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)