Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Jan 16, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Currently, due to the default values for the Baseinfectiouneses, the transmission risk is always zero in the vvs example. This is now fixed since the new Tranmission risk from a new variant is given with a relative factor.
  • We deleted the explicit Variant parameters
  • Adjusted test data since there was an error

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdc62ee) 95.60% compared to head (daa0ac2) 95.88%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   95.60%   95.88%   +0.27%     
==========================================
  Files         118      118              
  Lines        9448     9397      -51     
==========================================
- Hits         9033     9010      -23     
+ Misses        415      387      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu requested a review from reneSchm January 22, 2024 09:12
@HenrZu HenrZu requested a review from reneSchm January 23, 2024 09:35
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I'd like to see a few more changes.

HenrZu and others added 2 commits January 24, 2024 09:05
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@HenrZu HenrZu requested a review from reneSchm January 24, 2024 10:59
@HenrZu HenrZu merged commit 6391c30 into main Jan 25, 2024
@HenrZu HenrZu deleted the 888-Correct-apply_b161-for-default-case-and-make-more-generic branch January 25, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specialized SecirVVS function not working correctly when not setting BaseInfectiousnessB117 and BaseInfectiousnessB161

3 participants