Skip to content

Update pull_request_template.md #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Update pull_request_template.md #903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3a4803
Update pull_request_template.md
mknaranja Jan 16, 2024
ff8ca23
Update .github/pull_request_template.md
mknaranja Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
# Changes and Information

Please **briefly list the changes** made, additional Information and what the Reviewer should look out for:
Please **briefly list the changes** (main added features, changed items, or corrected bugs) made:

-
-
-


If need be, add additional information and what the reviewer should look out for in particular:

-
-

## Merge Request - Guideline Checklist
Expand All @@ -24,3 +32,4 @@ Please check our [git workflow](https://github.com/SciCompMod/memilio/wiki/git-w
- [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
- [ ] Appropriate **unit tests** have been added, CI passes, code coverage and performance is acceptable (did not decrease)
- [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the **briefly-list-the-changes** above (best case) or the separate commit messages (worst case).