Skip to content

Conversation

@xsaschako
Copy link
Member

@xsaschako xsaschako commented Dec 21, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • changed "EPI" to "MIO"
  • changed all appearances of "migration" or similar to "mobility" or similar
  • renamed "ABM::World" to "ABM::Model"

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

@xsaschako xsaschako linked an issue Dec 21, 2023 that may be closed by this pull request
@xsaschako xsaschako self-assigned this Dec 21, 2023
@xsaschako xsaschako requested review from DavidKerkmann and removed request for DavidKerkmann December 21, 2023 14:27
@codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: Patch coverage is 92.27273% with 17 lines in your changes missing coverage. Please review.

Project coverage is 96.12%. Comparing base (a97183a) to head (cb5b3ea).
Report is 1 commits behind head on main.

Files Patch % Lines
cpp/models/abm/model.cpp 76.59% 11 Missing ⚠️
...memilio/mobility/metapopulation_mobility_instant.h 95.91% 2 Missing ⚠️
...ilio/mobility/metapopulation_mobility_stochastic.h 86.66% 2 Missing ⚠️
cpp/models/abm/model.h 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   96.14%   96.12%   -0.02%     
==========================================
  Files         131      131              
  Lines       11047    11049       +2     
==========================================
  Hits        10621    10621              
- Misses        426      428       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsaschako xsaschako removed the request for review from DavidKerkmann December 22, 2023 09:18
@xsaschako xsaschako marked this pull request as draft December 22, 2023 09:57
@DavidKerkmann DavidKerkmann marked this pull request as ready for review July 3, 2024 21:41
@DavidKerkmann DavidKerkmann linked an issue Jul 8, 2024 that may be closed by this pull request
2 tasks
@DavidKerkmann DavidKerkmann changed the title Refactor ABM code: Rename EPI to MIO and mobility to movement Refactor ABM code: Rename EPI to MIO and migration to mobility and World to Model Jul 19, 2024
DavidKerkmann and others added 4 commits July 26, 2024 11:30
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
…f github.com:SciCompMod/memilio into 842-change-wording-replace-abm-migration-by-mobility
@DavidKerkmann DavidKerkmann requested a review from jubicker July 26, 2024 10:03
Copy link
Member

@mknaranja mknaranja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a superficial review but would think that it looks very good. Thank you very much for the immense work.

@DavidKerkmann DavidKerkmann requested a review from mknaranja July 30, 2024 15:38
@mknaranja mknaranja merged commit 8889b81 into main Jul 31, 2024
@mknaranja mknaranja deleted the 842-change-wording-replace-abm-migration-by-mobility branch July 31, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename world to model change wording: replace abm migration by mobility and epi by mio

5 participants