Skip to content

Conversation

@jubicker
Copy link
Member

@jubicker jubicker commented Oct 2, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

closes #721

@jubicker jubicker linked an issue Oct 2, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6d01187) 95.40% compared to head (f2ece21) 95.50%.
Report is 9 commits behind head on main.

Files Patch % Lines
cpp/models/ode_secir/parameters_io.cpp 98.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   95.40%   95.50%   +0.09%     
==========================================
  Files         117      118       +1     
  Lines        9231     9297      +66     
==========================================
+ Hits         8807     8879      +72     
+ Misses        424      418       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mknaranja mknaranja changed the title munich graph sim 721 Munich graph sim Oct 11, 2023
@jubicker jubicker requested a review from HenrZu December 4, 2023 08:19
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only some comments :)

jubicker and others added 3 commits December 15, 2023 10:55
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
jubicker and others added 2 commits December 21, 2023 13:38
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@jubicker jubicker merged commit 3b8cf9d into main Jan 3, 2024
@jubicker jubicker deleted the 721-graph-model-for-munich branch January 3, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph model for Munich

3 participants