Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Sep 15, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • added a different method to initialize the ide model. Is comparable to the method used for the ODE model for compartment Recovered. Examples and tests run correctly.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #769

@lenaploetzke lenaploetzke added prio::high The priority of this task is high. status::in review This issues is in review. loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. class::improvement Cleanup that doesn't affect functionality labels Sep 15, 2023
@lenaploetzke lenaploetzke self-assigned this Sep 15, 2023
@lenaploetzke lenaploetzke linked an issue Sep 15, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0363c4) 95.88% compared to head (704f83a) 96.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   95.88%   96.11%   +0.23%     
==========================================
  Files         118      118              
  Lines        9400     9425      +25     
==========================================
+ Hits         9013     9059      +46     
+ Misses        387      366      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke removed the status::in review This issues is in review. label Jan 15, 2024
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initialization! I added a few comments and questions, especially regarding the test.

lenaploetzke and others added 4 commits February 1, 2024 10:09
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
@lenaploetzke lenaploetzke added the status::in review This issues is in review. label Feb 5, 2024
@annawendler annawendler merged commit d4cb5ee into main Feb 16, 2024
@annawendler annawendler deleted the 769-new-initialization-for-ide-model branch February 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. prio::high The priority of this task is high. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Initialization for IDE model

3 participants