-
Notifications
You must be signed in to change notification settings - Fork 19
675 alternative computation of compartments in IDE model #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 129 129
Lines 10072 10087 +15
=======================================
+ Hits 9704 9719 +15
Misses 368 368 ☔ View full report in Codecov by Sentry. |
|
The pipeline currently failed only because of the lower patch coverage due to added lines. When PR #923 is merged, the code coverage will be at 100% also with the changes of this PR. |
mknaranja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lenaploetzke for these changes. I mostly have small suggestions (which however might change code lines in many occasions). Could you check them?
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
In order to reduce simulation time, compartment values in IDE SECIR model are now computed via last value and flow value of the current time step instead of historic flow values only. For the initialization, compartment values are computed using the sum formula from the flows as before. The order of the member functions is changed to clarify which functions are used to compute the initial size of the compartments and which functions are used for later time steps. Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com> Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com> Co-authored-by: René Schmieding <rene.schmieding@helmholtz-hzi.de>
Changes
Merge Request - GuideLine Checklist
Checks by code author
Checks by code reviewer(s)
Additional context
Please list additional information or things a reviewer should look out for.
Closes #675