Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Oct 23, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fix test file being created in the project directory.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm added class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. labels Oct 23, 2025
@reneSchm reneSchm requested a review from annawendler October 23, 2025 16:26
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (a38eeb8) to head (29b313b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
- Coverage   97.27%   97.24%   -0.04%     
==========================================
  Files         176      176              
  Lines       15441    15441              
==========================================
- Hits        15021    15016       -5     
- Misses        420      425       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@annawendler annawendler merged commit d871c54 into main Oct 24, 2025
57 checks passed
@annawendler annawendler deleted the fix-mobility-io-file-leak branch October 24, 2025 10:56
@jubicker jubicker moved this from ✅ Done (Sprint) to Done (Total) in MEmilio: Equation-Based-Models Development Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants