-
Notifications
You must be signed in to change notification settings - Fork 19
1350 Implement RSV model #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1350 Implement RSV model #1352
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
========================================
Coverage 97.27% 97.27%
========================================
Files 173 175 +2
Lines 15203 15306 +103
========================================
+ Hits 14788 14889 +101
- Misses 415 417 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kilianvolmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review the python bindings as I have never worked with them before. Can you ask somebody else for a review on that?
Co-authored-by: Kilian Volmer <13285635+kilianvolmer@users.noreply.github.com>
kilianvolmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C++ code looks fine for me now and I would approve it, but I haven't reviewed the Python code.
Co-authored-by: MaxBetz <104758467+MaxBetzDLR@users.noreply.github.com>
MaxBetzDLR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python code is good
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)