Skip to content

Conversation

@kilianvolmer
Copy link
Contributor

@kilianvolmer kilianvolmer commented Aug 11, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Moved GeographicLocation to memilio/geography/locations.h
  • Added a distance calculation for two GeographicLocations on the sphere
  • Added a wrapper for boosts r-Tree to work with GeographicLocation

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1342

@kilianvolmer kilianvolmer changed the title 1342 make geographic location available to all of m emilio 1342 make geographic location available to all of MEmilio Aug 11, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (08a6cf0) to head (89f0cc4).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1346    +/-   ##
========================================
  Coverage   97.26%   97.27%            
========================================
  Files         176      180     +4     
  Lines       15439    15642   +203     
========================================
+ Hits        15017    15215   +198     
- Misses        422      427     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kilianvolmer and others added 2 commits September 3, 2025 10:59
Co-authored-by: Carlotta Gerstein <100771374+charlie0614@users.noreply.github.com>
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: HenrZu <69154294+HenrZu@users.noreply.github.com>
kilianvolmer and others added 4 commits October 16, 2025 09:43
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…o' of github.com:SciCompMod/memilio into 1342-Make-GeographicLocation-available-to-all-of-MEmilio
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details:

kilianvolmer and others added 5 commits October 28, 2025 17:23
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…o' of github.com:SciCompMod/memilio into 1342-Make-GeographicLocation-available-to-all-of-MEmilio
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scrolled over all changes again, I think the code looks good. Maybe check your documentation again, I found a missing and floating docstring, but when that is done, I say this is ready for merging.

kilianvolmer and others added 2 commits October 29, 2025 13:33
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Copy link
Member

@charlie0614 charlie0614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kilianvolmer kilianvolmer merged commit 9da2316 into main Oct 29, 2025
45 checks passed
@kilianvolmer kilianvolmer deleted the 1342-Make-GeographicLocation-available-to-all-of-MEmilio branch October 29, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make GeographicLocation available for all of MEmilio

6 participants