-
Notifications
You must be signed in to change notification settings - Fork 19
1342 make geographic location available to all of MEmilio #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1342 make geographic location available to all of MEmilio #1346
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
========================================
Coverage 97.26% 97.27%
========================================
Files 176 180 +4
Lines 15439 15642 +203
========================================
+ Hits 15017 15215 +198
- Misses 422 427 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Carlotta Gerstein <100771374+charlie0614@users.noreply.github.com> Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: HenrZu <69154294+HenrZu@users.noreply.github.com>
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…o' of github.com:SciCompMod/memilio into 1342-Make-GeographicLocation-available-to-all-of-MEmilio
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few details:
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…o' of github.com:SciCompMod/memilio into 1342-Make-GeographicLocation-available-to-all-of-MEmilio
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scrolled over all changes again, I think the code looks good. Maybe check your documentation again, I found a missing and floating docstring, but when that is done, I say this is ready for merging.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
charlie0614
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
GeographicLocationtomemilio/geography/locations.hGeographicLocations on the sphereGeographicLocationIf need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1342