Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Jul 10, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Mocking dependencies for sphinx build
  • set collapse_navigation to true leads to ~50% faster build

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and explanations in the online documentation)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Jul 10, 2025 that may be closed by this pull request
2 tasks
@HenrZu HenrZu requested a review from kilianvolmer July 10, 2025 08:48
@HenrZu HenrZu merged commit 3a0d789 into main Jul 10, 2025
44 checks passed
@HenrZu HenrZu deleted the 1312-Accelerate-documentation-build-by-mocking-dependencies branch July 10, 2025 09:00
@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (27c9ce8) to head (80cd2c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         171      171           
  Lines       15117    15117           
=======================================
  Hits        14705    14705           
  Misses        412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu mentioned this pull request Jul 15, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accelerate documentation build by mocking dependencies

3 participants