Skip to content

Conversation

@xsaschako
Copy link
Member

@xsaschako xsaschako commented Jun 22, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fix test

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@xsaschako xsaschako linked an issue Jun 22, 2025 that may be closed by this pull request
2 tasks
@xsaschako xsaschako self-assigned this Jun 22, 2025
@xsaschako xsaschako requested review from reneSchm and removed request for reneSchm June 22, 2025 18:59
@codecov
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (b6f044d) to head (e8c0fd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1301   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         168      168           
  Lines       14858    14858           
=======================================
  Hits        14454    14454           
  Misses        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jubicker
Copy link
Member

Please rerun the failing CI check

@reneSchm reneSchm changed the title ci fail surragetemodel test 1300 Update surragete model test to work with new pyfakefs version Jun 23, 2025
@HenrZu
Copy link
Contributor

HenrZu commented Jun 23, 2025

Thank you for the quick fix :)
One question. Doesn't it fail now, if we use an older version? maybe it makes more sense if we limit the allowed version?

@xsaschako
Copy link
Member Author

xsaschako commented Jun 23, 2025

I'll change it to a wildcard for the string so that is more version independent.

@HenrZu
Copy link
Contributor

HenrZu commented Jun 23, 2025

I'll change it to a wildcard for the string so that is more version independent.

thanks 👍

@xsaschako xsaschako requested a review from jubicker June 23, 2025 10:17
@xsaschako xsaschako merged commit 83c57ad into main Jun 23, 2025
56 checks passed
@xsaschako xsaschako deleted the 1300-ci-fail-surrogatemodel-test branch June 23, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Fail surrogatemodel test

4 participants