Skip to content

Conversation

@xsaschako
Copy link
Member

@xsaschako xsaschako commented May 20, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • EXPECT_EQ ->EXPECT_NEAR

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@xsaschako xsaschako requested a review from HenrZu May 20, 2025 14:02
@xsaschako xsaschako self-assigned this May 20, 2025
@xsaschako xsaschako linked an issue May 20, 2025 that may be closed by this pull request
2 tasks
@HenrZu
Copy link
Contributor

HenrZu commented May 20, 2025

i think the issue is not corresponding to the problem here. In the Issue, its for the test TestGraphSimulation.consistencyStochasticMobility while this here fixes the test ModelTestOdeSecir, export_time_series_init_old_date

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (c7f439d) to head (3ffbabb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         156      156           
  Lines       14674    14674           
=======================================
  Hits        14266    14266           
  Misses        408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsaschako
Copy link
Member Author

i think the issue is not corresponding to the problem here. In the Issue, its for the test TestGraphSimulation.consistencyStochasticMobility while this here fixes the test ModelTestOdeSecir, export_time_series_init_old_date

See comment in that issue

@xsaschako xsaschako merged commit 2d50c90 into main May 26, 2025
56 checks passed
@xsaschako xsaschako deleted the 703-different-output-for-mac-silicon branch May 26, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different Output for Mac Silicon

3 participants