Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Apr 3, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm added the loc::python interface This issue concerns the python interface to the backend implementation. label Apr 3, 2025
@reneSchm reneSchm requested a review from HenrZu April 3, 2025 11:24
@reneSchm reneSchm self-assigned this Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (049e8df) to head (db4e359).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1240    +/-   ##
========================================
  Coverage   97.22%   97.23%            
========================================
  Files         154      155     +1     
  Lines       14236    14350   +114     
========================================
+ Hits        13841    13953   +112     
- Misses        395      397     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu merged commit 12b041d into main Apr 3, 2025
114 checks passed
@HenrZu HenrZu deleted the bump-minimum-cmake-versions-in-pycode branch April 3, 2025 12:04
@jubicker jubicker moved this from ✅ Done (Sprint) to Done (Total) in MEmilio: Equation-Based-Models Development Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc::python interface This issue concerns the python interface to the backend implementation.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants