Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Mar 31, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm requested a review from HenrZu March 31, 2025 09:25
@reneSchm reneSchm added loc::backend This issue concerns the C++ backend implementation. model::sde This issue concerns any kind of stochastic differential equation-based model. labels Mar 31, 2025
@reneSchm reneSchm self-assigned this Mar 31, 2025
@reneSchm reneSchm merged commit db770f7 into main Apr 2, 2025
102 of 106 checks passed
@reneSchm reneSchm deleted the remove-debug-output-from-sde_seirvv branch April 2, 2025 10:32
@jubicker jubicker moved this from ✅ Done (Sprint) to Done (Total) in MEmilio: Equation-Based-Models Development Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc::backend This issue concerns the C++ backend implementation. model::sde This issue concerns any kind of stochastic differential equation-based model.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants