Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Mar 12, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Initial version for readthedocs (mainly written by kilian)

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Co-authored-by: Kilian Volmer <kvolmer@uni-bonn.de>
@HenrZu HenrZu changed the title Preparation for readthedocs (#1216) 1216 Preparation for readthedocs Mar 12, 2025
@HenrZu HenrZu linked an issue Mar 12, 2025 that may be closed by this pull request
2 tasks
@HenrZu HenrZu changed the title 1216 Preparation for readthedocs 1215 Preparation for readthedocs Mar 12, 2025
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (35acc29) to head (df825ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
- Coverage   97.21%   97.20%   -0.02%     
==========================================
  Files         154      154              
  Lines       14203    14203              
==========================================
- Hits        13808    13806       -2     
- Misses        395      397       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu requested a review from kilianvolmer March 12, 2025 13:17
@kilianvolmer
Copy link
Contributor

Apparently, the automatic docstring formatter had problems when parts of the parameters were already documented. All of the docstrings have to be checked again.

Copy link
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstrings for the python functions will be fixed next week. I approve this PR to set up readthedocs until then.

@HenrZu HenrZu merged commit 87c41a7 into main Mar 14, 2025
67 of 70 checks passed
@HenrZu HenrZu deleted the 1215-Preparation-read-the-docs branch March 14, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initialization of Read the Docs

3 participants