-
Notifications
You must be signed in to change notification settings - Fork 19
410 Make IDE model compatible with graph #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 97.13% 97.23% +0.09%
==========================================
Files 149 155 +6
Lines 13999 14282 +283
==========================================
+ Hits 13598 13887 +289
+ Misses 401 395 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, only some small issues with the FP template.
There is not a lot of new testing, but this PR is mainly an application of existing code, so it is enough.
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the corrections in metapopulation_mobility_instant.h, I only have two more comments on the main file.
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Line cpp/memilio/mobility/metapopulation_mobility_instant.h:577 was not covered before and is only marked due to minor fixes (changing double to FP).
Changes and Information
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #410