Skip to content

Conversation

@annawendler
Copy link
Member

@annawendler annawendler commented Feb 12, 2025

Changes and Information

  • Added graph simulation without mobility so that also IDE model can be used within graph.
  • Added test.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #410

@annawendler annawendler linked an issue Feb 12, 2025 that may be closed by this pull request
@annawendler annawendler changed the title 410 make IDE model compatible with graph 410 Make IDE model compatible with graph Feb 12, 2025
@annawendler annawendler self-assigned this Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.23%. Comparing base (34a0277) to head (be53190).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...memilio/mobility/metapopulation_mobility_instant.h 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
+ Coverage   97.13%   97.23%   +0.09%     
==========================================
  Files         149      155       +6     
  Lines       13999    14282     +283     
==========================================
+ Hits        13598    13887     +289     
+ Misses        401      395       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@annawendler annawendler requested a review from reneSchm February 13, 2025 08:12
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, only some small issues with the FP template.

There is not a lot of new testing, but this PR is mainly an application of existing code, so it is enough.

@annawendler annawendler requested a review from reneSchm March 28, 2025 15:32
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections in metapopulation_mobility_instant.h, I only have two more comments on the main file.

@annawendler annawendler requested a review from reneSchm April 4, 2025 14:01
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Line cpp/memilio/mobility/metapopulation_mobility_instant.h:577 was not covered before and is only marked due to minor fixes (changing double to FP).

@annawendler annawendler merged commit 3390762 into main Apr 7, 2025
57 of 58 checks passed
@annawendler annawendler deleted the 410-make-ide-model-compatible-with-graph branch April 7, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make IDE model compatible with graph model

3 participants