Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Dec 13, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Non model dependent io function of the population, case, divi are now saved centrally once.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Dec 13, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base (c7f439d) to head (fd8fb0e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cpp/memilio/io/parameters_io.h 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
+ Coverage   97.21%   97.28%   +0.06%     
==========================================
  Files         156      168      +12     
  Lines       14674    14858     +184     
==========================================
+ Hits        14266    14454     +188     
+ Misses        408      404       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu changed the title 1108 Reuse more code in Initialization Process of ODE models 1108 Reuse more code when read in data in model specific IO files Mar 21, 2025
@jubicker jubicker changed the title 1108 Reuse more code when read in data in model specific IO files 1108 Streamline code for reading in data in model specific IO files Apr 24, 2025
@HenrZu HenrZu requested a review from jubicker May 30, 2025 12:09
HenrZu and others added 3 commits June 17, 2025 09:17
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
@HenrZu HenrZu requested a review from jubicker June 17, 2025 11:33
@HenrZu HenrZu merged commit b6f044d into main Jun 18, 2025
55 of 56 checks passed
@HenrZu HenrZu deleted the 1108-Reuse-more-code-in-Initialization-Process-of-ODE-models branch June 18, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamline code for reading in data in model specific IO files

3 participants