Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Dec 6, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Catch case where the subpopulation size is zero.
  • This can happen e.g. if all individuals in the subpopulation die. If this is not handled, we get NaNs in the simulation.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1144.

@lenaploetzke lenaploetzke linked an issue Dec 6, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke changed the title 1144 handle case when group size is equal to 0 for the-model 1144 handle case when group size is equal to 0 for the LCT model Dec 6, 2024
@lenaploetzke lenaploetzke self-assigned this Dec 6, 2024
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (f76d14f) to head (d2b3ff0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   96.98%   96.96%   -0.02%     
==========================================
  Files         142      142              
  Lines       11873    11874       +1     
==========================================
- Hits        11515    11514       -1     
- Misses        358      360       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke
Copy link
Member Author

I don't know what happened to the project coverage. Codecov marked an abm file, but that was not changed here.

@lenaploetzke lenaploetzke requested a review from reneSchm December 6, 2024 13:01
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I don't know what is up with the coverage, but this change does not impact tests (especially ones for the ABM).

@lenaploetzke lenaploetzke merged commit 3a06d82 into main Dec 6, 2024
57 of 58 checks passed
@lenaploetzke lenaploetzke deleted the 1144-handle-the-case-if-the-group-size-is-equal-to-0-for-the-lct-model branch December 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle the case if the group size is equal to 0 for the LCT model

3 participants