-
Notifications
You must be signed in to change notification settings - Fork 19
1148 Rework Data structure and Rename Mobility and Vaccination file #1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 97.21% 97.20% -0.02%
==========================================
Files 154 154
Lines 14203 14193 -10
==========================================
- Hits 13808 13796 -12
- Misses 395 397 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
To validate the changes, I ran the Simulation once in the current main and in this branch once in cpp and once in python while saving the graph and compared it then. The results are identical to the previous one. |
xsaschako
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If you can answer the one question i'd be happy but i approve for now.
xsaschako
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
all_county_ageinf_vacctovacc_county_ageinfgetSimulationDatato really provide all files to execute the simulations.If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)