Skip to content

Conversation

@dr2001dlr
Copy link
Collaborator

@dr2001dlr dr2001dlr commented Oct 24, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • New class Visualization in graph_visualization.py
  • Ast output as file, output in terminal or as an png
  • Changes in scanner.py
  • New class for AST

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1138

… the ast as png with a starting node and max depth, added get_node_by_index to search a node based on its index in the cursor_nodes list. Not complete.
@dr2001dlr dr2001dlr self-assigned this Oct 24, 2024
@dr2001dlr dr2001dlr linked an issue Oct 24, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (0962eb0) to head (6f8a535).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1140   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         137      137           
  Lines       11057    11057           
=======================================
  Hits        10680    10680           
  Misses        377      377           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr2001dlr dr2001dlr requested a review from MaxBetzDLR October 25, 2024 09:08
@dr2001dlr dr2001dlr added the class::feature A feature to be implemented for some part of the software label Oct 28, 2024
Copy link
Member

@MaxBetzDLR MaxBetzDLR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs some small adjustments.

@MaxBetzDLR
Copy link
Member

The example still uses the old print function and scanner. Update the file and add the graphviz.

@MaxBetzDLR MaxBetzDLR merged commit 0134012 into main Nov 7, 2024
58 checks passed
@MaxBetzDLR MaxBetzDLR deleted the 1138-plot-functions-for-ast-in-generation-package branch November 7, 2024 10:24
@mknaranja mknaranja changed the title 1138 plot functions for ast in generation package 1138 plot functions for AST in generation package Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software

Projects

Development

Successfully merging this pull request may close these issues.

Plot functions for ast in generation package

3 participants