Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Sep 18, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Add ExplicitStepperWrapper class. Allows using non-adaptive explicit steppers from boost.
  • Extend Euler integration test for new steppers.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm added class::feature A feature to be implemented for some part of the software prio::low The priority of this task is low. It is an interesting item but with low priority. loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. labels Sep 18, 2024
@reneSchm reneSchm requested a review from HenrZu September 18, 2024 09:06
@reneSchm reneSchm self-assigned this Sep 18, 2024
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice and is a nice addition :) Just commented on a few little things about the documentation.

@reneSchm reneSchm requested a review from HenrZu September 19, 2024 13:56
@HenrZu HenrZu merged commit 9b2aed4 into main Sep 19, 2024
@HenrZu HenrZu deleted the explicit-stepper-wrapper branch September 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::low The priority of this task is low. It is an interesting item but with low priority.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants