Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Sep 2, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added the possibility to use groups (e.g. age groups) in the LCT-SECIR model. The parameters and the number of subcompartments can be set differently for each group.
  • Adapted functionality to initialize the model.
  • Added tests.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #896

@lenaploetzke lenaploetzke self-assigned this Sep 2, 2024
@lenaploetzke lenaploetzke linked an issue Sep 2, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (896a04e) to head (26b509a).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   96.44%   96.58%   +0.13%     
==========================================
  Files         135      137       +2     
  Lines       11286    11030     -256     
==========================================
- Hits        10885    10653     -232     
+ Misses        401      377      -24     
Flag Coverage Δ
96.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

What I found hard to understand at first was that LctStates contains the number of subcompartments and not the subcompartments themselves. Maybe this could be made clearer by renaming it to NumLctStates or a more detailed explanation in the Populations class (or both).

lenaploetzke and others added 2 commits September 16, 2024 09:43
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the compile time recursion. I have several nitpicks comments on general design, I hope this is as intended.

lenaploetzke and others added 2 commits September 19, 2024 14:21
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes. I only have some small issues with the details around is_age_resolved_entry_type.

lenaploetzke and others added 2 commits September 30, 2024 08:35
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that I could have answered the question whether a specific EntryType was expected myself, it says so in the doc string.
Anyways, the changes look good.

@reneSchm reneSchm merged commit 125e1d2 into main Sep 30, 2024
@reneSchm reneSchm deleted the 896-add-age-resolved-lct-model branch September 30, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add age resolved LCT model

4 participants