-
Notifications
You must be signed in to change notification settings - Fork 19
896 add age resolved lct model #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
+ Coverage 96.44% 96.58% +0.13%
==========================================
Files 135 137 +2
Lines 11286 11030 -256
==========================================
- Hits 10885 10653 -232
+ Misses 401 377 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
annawendler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
What I found hard to understand at first was that LctStates contains the number of subcompartments and not the subcompartments themselves. Maybe this could be made clearer by renaming it to NumLctStates or a more detailed explanation in the Populations class (or both).
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the compile time recursion. I have several nitpicks comments on general design, I hope this is as intended.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
…milio into 896-add-age-resolved-lct-model
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice changes. I only have some small issues with the details around is_age_resolved_entry_type.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that I could have answered the question whether a specific EntryType was expected myself, it says so in the doc string.
Anyways, the changes look good.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #896