Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Sep 2, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • remove cwiseMax to also update for negative damping coefficients.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Sep 2, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (d4ed967) to head (282aebf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   96.44%   96.41%   -0.04%     
==========================================
  Files         135      135              
  Lines       11286    11285       -1     
==========================================
- Hits        10885    10880       -5     
- Misses        401      405       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu merged commit a1028b5 into main Sep 3, 2024
@HenrZu HenrZu deleted the 1118-Update-active-dampings-for-negative-coefficients branch September 3, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update of Damping not working with negative coefficients

3 participants