Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Aug 22, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fix bug in cmake

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1113

@MaxBetzDLR MaxBetzDLR linked an issue Aug 22, 2024 that may be closed by this pull request
2 tasks
@MaxBetzDLR MaxBetzDLR self-assigned this Aug 22, 2024
@MaxBetzDLR MaxBetzDLR added the class::bug Bugs found in the software label Aug 22, 2024
@MaxBetzDLR MaxBetzDLR requested a review from dabele August 22, 2024 07:37
@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (896a04e) to head (6ff02d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         135      135           
  Lines       11286    11286           
=======================================
  Hits        10885    10885           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBetzDLR MaxBetzDLR requested a review from dabele August 22, 2024 08:24
@dabele dabele merged commit a7660d8 into main Aug 22, 2024
@dabele dabele deleted the 1113-missing-includes-in-python-bindings branch August 22, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software

Projects

Development

Successfully merging this pull request may close these issues.

Missing includes in python bindings

3 participants