-
Notifications
You must be signed in to change notification settings - Fork 19
1084 Handle Epidata FutureWarnings #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
annawendler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work :)
In getNPIData.py, line 918 I still get the following future warning:
"FutureWarning: Downcasting behavior in replace is deprecated and will be removed in a future version. To retain the old behavior, explicitly call result.infer_objects(copy=False). To opt-in to the future behavior, set pd.set_option('future.no_silent_downcasting', True)".
In line 1498 I also get the error "AttributeError: module 'matplotlib.cm' has no attribute 'get_cmap'"
Do you also oberve this?
Another thing: In the issue you mention a future in getCaseData.py. When running this script I didn't get any warnings although you didn't change anything. Did it only occur in the test case? Also you didn't mention getNPIData in the issue. Can you edit the issue accordingly?
pycode/memilio-epidata/memilio/epidata_test/test_epidata_get_vaccination_data.py
Outdated
Show resolved
Hide resolved
annawendler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By inferring the type of the df first I could avoid the future warning. Can you adapt the comment? Then I can merge :)
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1084