Skip to content

Conversation

@patricklnz
Copy link
Member

@patricklnz patricklnz commented Aug 16, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • handle FutureWarnings from newest pandas version

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1084

@patricklnz patricklnz self-assigned this Sep 16, 2024
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work :)

In getNPIData.py, line 918 I still get the following future warning:
"FutureWarning: Downcasting behavior in replace is deprecated and will be removed in a future version. To retain the old behavior, explicitly call result.infer_objects(copy=False). To opt-in to the future behavior, set pd.set_option('future.no_silent_downcasting', True)".

In line 1498 I also get the error "AttributeError: module 'matplotlib.cm' has no attribute 'get_cmap'"

Do you also oberve this?

Another thing: In the issue you mention a future in getCaseData.py. When running this script I didn't get any warnings although you didn't change anything. Did it only occur in the test case? Also you didn't mention getNPIData in the issue. Can you edit the issue accordingly?

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By inferring the type of the df first I could avoid the future warning. Can you adapt the comment? Then I can merge :)

Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
@annawendler annawendler merged commit 86eb344 into main Oct 28, 2024
12 checks passed
@annawendler annawendler deleted the 1084-epidata-futurewarnings branch October 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FutureWarnings in epidata code

3 participants