Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Aug 12, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Bind IntegratorCore
  • Expose 3 often used Types of IntegratorCores to python
  • Update Simulation and model specific simulate bindings

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1098

@MaxBetzDLR MaxBetzDLR added loc::python interface This issue concerns the python interface to the backend implementation. class::improvement Cleanup that doesn't affect functionality labels Aug 12, 2024
@MaxBetzDLR MaxBetzDLR self-assigned this Aug 12, 2024
@MaxBetzDLR MaxBetzDLR linked an issue Aug 12, 2024 that may be closed by this pull request
2 tasks
@MaxBetzDLR MaxBetzDLR requested a review from jubicker August 12, 2024 06:46
@codecov
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (a7660d8) to head (1ff7925).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         135      135           
  Lines       11286    11286           
=======================================
  Hits        10885    10885           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jubicker
Copy link
Member

Please tick the check boxes if they are fullfilled

@MaxBetzDLR MaxBetzDLR requested a review from jubicker August 22, 2024 07:14
@jubicker jubicker merged commit d4ed967 into main Aug 22, 2024
@jubicker jubicker deleted the 1098-bind-different-integrators-for-python branch August 22, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality loc::python interface This issue concerns the python interface to the backend implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bind different integrators for python

3 participants