Skip to content

Conversation

@annawendler
Copy link
Member

@annawendler annawendler commented Aug 7, 2024

Changes and Information

  • RKI reports deaths with respect to the infection date of the respective person. We shift the reported data according to the respective mean stay times to get information on when people died.
  • Depending on the chosen transition distributions and the start date we need data points before reporting of Covid cases started. We set these data points to 0.
  • Compute flow ExposedToInfectedNoSymptoms from -2*global_support_max,...,0 to allow correct initialization of flow InfectedNoSymptomsTorecovered.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1087

@annawendler annawendler linked an issue Aug 7, 2024 that may be closed by this pull request
@annawendler annawendler self-assigned this Aug 7, 2024
@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (a029aa6) to head (444e0c6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   96.42%   96.44%   +0.01%     
==========================================
  Files         132      135       +3     
  Lines       11055    11286     +231     
==========================================
+ Hits        10660    10885     +225     
- Misses        395      401       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawendler annawendler removed the request for review from lenaploetzke August 7, 2024 12:07
@lenaploetzke lenaploetzke changed the title adapt parameters_io 1087 adapt parameters_io of ide model Aug 8, 2024
Copy link
Member

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adapting the number of deaths and especially for finding the bug!

@lenaploetzke lenaploetzke merged commit 0f3158c into main Aug 9, 2024
@lenaploetzke lenaploetzke deleted the 1087-adapt-parameters_io-of-ide-model branch August 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt parameters_io of IDE model

3 participants