Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Jul 24, 2024

Changes and Information

The code coverage misses certain lines, e.g. the closing } of a (non-void) lambda. Disabling inlining and ellision lets the coverage actually find those lines, but theoretically decreases performance, when compiling with both Debug mode and with coverage enabled.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm requested a review from lenaploetzke July 24, 2024 12:31
@reneSchm reneSchm self-assigned this Jul 24, 2024
@reneSchm reneSchm added loc::continuous integration This issue concerns any problem of continuous integration. class::improvement Cleanup that doesn't affect functionality labels Jul 24, 2024
@reneSchm reneSchm changed the title disable some gcc optimisations so that the code coverage does not mis… Increase accuracy of code coverage Jul 24, 2024
@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (7518ea3) to head (f7c1e24).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   96.14%   96.42%   +0.28%     
==========================================
  Files         131      132       +1     
  Lines       11047    11053       +6     
==========================================
+ Hits        10621    10658      +37     
+ Misses        426      395      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
@lenaploetzke lenaploetzke merged commit a029aa6 into main Aug 1, 2024
@lenaploetzke lenaploetzke deleted the improve-accuracy-of-coverage branch August 1, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality loc::continuous integration This issue concerns any problem of continuous integration.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants