Skip to content

Conversation

@patricklnz
Copy link
Member

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • remove credentials

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1073

@patricklnz patricklnz self-assigned this Jul 22, 2024
@patricklnz patricklnz requested a review from jubicker July 22, 2024 08:56
@codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (7d46233) to head (0cc642a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files         131      131           
  Lines       11047    11049    +2     
=======================================
+ Hits        10621    10623    +2     
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patricklnz patricklnz requested a review from jubicker August 1, 2024 11:49
@patricklnz patricklnz merged commit 896a04e into main Aug 13, 2024
@patricklnz patricklnz deleted the 1073-remove-credentials branch August 13, 2024 07:09
@mknaranja
Copy link
Member

@patricklnz and why have the credentials been removed? please provide details and also always check boxes! please also check this always @jubicker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No credentials needed for population data download

4 participants