Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Jul 10, 2024

Changes and Information

See title.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm added class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. labels Jul 10, 2024
@reneSchm reneSchm requested a review from HenrZu July 10, 2024 09:50
@reneSchm reneSchm self-assigned this Jul 10, 2024
@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (9cf30ee) to head (6c2eee0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         127      127           
  Lines       10887    10887           
=======================================
  Hits        10478    10478           
  Misses        409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reneSchm reneSchm merged commit 604afb1 into main Jul 11, 2024
@reneSchm reneSchm deleted the remove-print-from-seir-test branch July 11, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants