1061 change return type of check_constraints function in the populations class to bool

[lenaploetzke]

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

• Changed return type from void to bool in check_ and apply_constraints functions of Populations and CompartmentalModel
• Added tests for functions in Populations

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

• Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
• New code adheres to coding guidelines
• No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• Tests are added for new functionality and a local test run was successful (with and without OpenMP)
• Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
• Proper attention to licenses, especially no new third-party software with conflicting license has been added
• (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

• Corresponding issue(s) is/are linked and addressed
• Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
• Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
• No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1061.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (d59fbd7) to head (0b4f1e6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   96.08%   96.14%   +0.05%     
==========================================
  Files         131      131              
  Lines       11048    11047       -1     
==========================================
+ Hits        10616    10621       +5     
+ Misses        432      426       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reneSchm]

I found a typo and a double space, but otherwise this is ready for a merge. Please consider adding the other two the suggestions.