Skip to content

Conversation

@hatrit
Copy link
Member

@hatrit hatrit commented Jun 20, 2024

Changes and Information

extend the test checkProportionRecoveredDeath, we now check if the compartments E,I,C,U and H are empty at the equilibrium.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1037

…compartments E,C,I,H and U are almost empty at the end of the simulation.
@hatrit hatrit requested a review from annawendler June 20, 2024 09:06
@hatrit hatrit linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's check formatting before merging :)

@codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (575a146) to head (64de150).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   96.23%   96.27%   +0.04%     
==========================================
  Files         128      128              
  Lines       10852    10993     +141     
==========================================
+ Hits        10443    10584     +141     
  Misses        409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawendler annawendler merged commit e3699f9 into main Jul 11, 2024
@annawendler annawendler deleted the 1037-extend-test-for-equilibrium-of-ide-model branch July 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend Test for equilibrium of IDE Model

3 participants