Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Jun 11, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fix a bug where OdeIntegrator would run indefinitely.
  • Add dt_min/dt_max to IntegratorCore.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm changed the title Fix last step size via adding dt_min/max to IntegratorCore 1038 OdeIntegrator can run indefinitely v2 Jun 11, 2024
@reneSchm reneSchm requested review from HenrZu and lenaploetzke June 12, 2024 07:25
@reneSchm reneSchm linked an issue Jun 12, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (0c73489) to head (8821a79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   96.23%   96.21%   -0.02%     
==========================================
  Files         128      128              
  Lines       10852    10867      +15     
==========================================
+ Hits        10443    10456      +13     
- Misses        409      411       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First feedback. Need some more time to check/ verify everything

@reneSchm reneSchm self-assigned this Jun 13, 2024
@reneSchm reneSchm added class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. labels Jun 14, 2024
Copy link
Member

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think this solution is much better than the first version. I only have a few small comments.

@reneSchm reneSchm requested review from HenrZu and lenaploetzke June 24, 2024 14:41
@reneSchm reneSchm merged commit 9ee0b56 into main Jun 25, 2024
@reneSchm reneSchm deleted the 1038-odeintegrator-can-run-indefinitely-v2 branch June 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OdeIntegrator can run indefinitely

4 participants