-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dict-like methods of Dataset
.
#153
Merged
Merged
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9fb8d52
Dict-like methods
YooSunYoung fd190ec
Dict-like methods tests
YooSunYoung bad61a9
Add dict-like get/setitem and setdefault tests including wrong/invali…
YooSunYoung 0e5ac32
Update docstring of dataset
YooSunYoung 543dfdc
Merge branch 'main' into dict-like-methods
YooSunYoung 5bd086a
Remove unsupported type hints in py38
YooSunYoung 7126175
Merge branch 'dict-like-methods' of github.com:SciCatProject/scitacea…
YooSunYoung 6f78d61
Add versionadded tag with release placeholder and parameters in the d…
YooSunYoung 0553f71
Update src/scitacean/dataset.py
YooSunYoung 294f4bc
Update src/scitacean/dataset.py
YooSunYoung dbfbd5f
Use dataset strategies instead of separate type fixture
YooSunYoung a1b60b9
Remove setdefault interface
YooSunYoung 2235ef3
Merge branch 'main' into dict-like-methods
YooSunYoung 21b0e40
Update releasnote about new features, dict-like methods
YooSunYoung d9ff2dc
Move versionadded mark above the sub titles.
YooSunYoung b18ec69
Move new version tag to the bottom of the docstring
YooSunYoung 48bfc2f
Merge branch 'main' into dict-like-methods
YooSunYoung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move those directives to the very end of the docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jl-wynen
It seems like it doesn't work if it is not above the sub-titles...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an annoyance with restructured text. You need two empty lines to 'return' from the previous section. I just added this to the coding conventions: https://github.com/SciCatProject/scitacean/blob/main/docs/developer/coding-conventions.rst