Make type readonly #150
Merged
Make type readonly #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
force-pushed
the
make-type-readonly
branch
from
80beef7
to
bf3d043
Compare
jl-wynen
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146.
This is not finished.Setting thetypefield readonly makesreplacenot give it in the constructor - causing lots of test errors.The fix was to remove the setter for
type, but not mark it to bereadonly.This caused some tests that assumed all non-readonly fields were settable to fail.
To avoid the test failures type was explicitly removed from the list of fields tested in the
test_can_set_writable_fieldstest.