Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate dataset #148

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Validate dataset #148

merged 10 commits into from
Oct 2, 2023

Commits on Sep 29, 2023

  1. add validate method on scicat client and add initial test

    @nvaytet
    nvaytet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    86c1494 View commit details
    Browse the repository at this point in the history

  2. fix

    @jokasimr
    jokasimr committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    082795d View commit details
    Browse the repository at this point in the history

  3. use dataset model instead of dataset

    @nvaytet
    nvaytet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f5a772f View commit details
    Browse the repository at this point in the history

  4. add the same method to the fake client

    @jokasimr
    jokasimr committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e3b82d9 View commit details
    Browse the repository at this point in the history

  5. make new model before creating dataset model, raise ValidationError, … 

    …use contactEmail instead of type in test
    @nvaytet
    nvaytet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a7db63a View commit details
    Browse the repository at this point in the history

  6. Apply automatic formatting

    @nvaytet @github-actions
    nvaytet authored and github-actions[bot] committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    05fa5f1 View commit details
    Browse the repository at this point in the history

  7. add test that no dataset is made when trying to upload but validation… 

    … fails
    @nvaytet
    nvaytet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0c456c5 View commit details
    Browse the repository at this point in the history

  8. use ValueError instead of ValidationError

    @nvaytet
    nvaytet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8f2f174 View commit details
    Browse the repository at this point in the history

  9. remove unused imports

    @nvaytet
    nvaytet committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    eb5ff88 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into validate-dataset

    @jl-wynen
    jl-wynen authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    329ea0d View commit details
    Browse the repository at this point in the history