Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added findByIdAccess method to Proposal and Sample APIs #1529

Merged

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Jul 22, 2024

Description

Added user access pre-check APIs for Proposal and Sample to prevent FALSY error collection. This PR depends on SciCatProject/scicat-backend-next#1327.

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

@Junjiequan Junjiequan force-pushed the SWAP-4091-scicat-be-create-a-permission-check-endpoint-for branch from 28617de to 71808ae Compare July 24, 2024 20:51
@Junjiequan Junjiequan requested a review from nitrosx July 29, 2024 15:09
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocking issue!!!
I wonder if we can import the username and passwords from functional accounts file used in tests

@nitrosx nitrosx merged commit 0687989 into master Jul 30, 2024
6 of 7 checks passed
@nitrosx nitrosx deleted the SWAP-4091-scicat-be-create-a-permission-check-endpoint-for branch July 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants