-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added findByIdAccess method to Proposal and Sample APIs #1529
Merged
nitrosx
merged 10 commits into
master
from
SWAP-4091-scicat-be-create-a-permission-check-endpoint-for
Jul 30, 2024
Merged
feat: Added findByIdAccess method to Proposal and Sample APIs #1529
nitrosx
merged 10 commits into
master
from
SWAP-4091-scicat-be-create-a-permission-check-endpoint-for
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junjiequan
force-pushed
the
SWAP-4091-scicat-be-create-a-permission-check-endpoint-for
branch
from
July 24, 2024 20:51
28617de
to
71808ae
Compare
Quality Gate failedFailed conditions |
nitrosx
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocking issue!!!
I wonder if we can import the username and passwords from functional accounts file used in tests
nitrosx
deleted the
SWAP-4091-scicat-be-create-a-permission-check-endpoint-for
branch
July 30, 2024 13:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added user access pre-check APIs for Proposal and Sample to prevent
FALSY
error collection. This PR depends on SciCatProject/scicat-backend-next#1327.Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version