fix main bugs

.github/workflows/release.yml

@@ -0,0 +1,38 @@
+name: Validate Release
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v4
+        with:
+          go-version: 1.20
+
+      - name: Install dependencies
+        run: go mod tidy
+
+      - name: Validate release.toml
+        run: go run scripts/validate_release.go
+
+  merge:
+    needs: validate
+    runs-on: ubuntu-latest
+    if: github.event.pull_request.merged == true
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Move release.toml
+        run: |
+          mv release.toml releases/$(date +%s)_release.toml

README.md

@@ -1,9 +1,3 @@
-# Schwarz IT Code Review Repository
-
-This repository is meant to be used in the onboarding process of Go developers
-applying to Schwarz IT.
-
-Code smells and security issues are made on purpose. All the code to be reviewed is
-in the [review](review) directory.
-
+# Overview
 
+This repository was created from the repository at https://github.com/SchwarzIT/go-code-review to make corrections and improvements

review/go.mod → go.mod

@@ -21,6 +21,7 @@ require (
 	github.com/mitchellh/mapstructure v1.5.0 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
+	github.com/pelletier/go-toml v1.9.5 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/stretchr/testify v1.7.1 // indirect

review/go.sum → go.sum

@@ -53,6 +53,8 @@ github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9G
 github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk=
 github.com/onsi/ginkgo/v2 v2.1.4 h1:GNapqRSid3zijZ9H77KrgVG4/8KqiyRsxcSxe+7ApXY=
 github.com/onsi/gomega v1.19.0 h1:4ieX6qQjPP/BfC3mpsAtIGGlxTWPeA3Inl/7DtXw1tw=
+github.com/pelletier/go-toml v1.9.5 h1:4yBQzkHv+7BHq2PQUZF3Mx0IYxG7LsP222s7Agd3ve8=
+github.com/pelletier/go-toml v1.9.5/go.mod h1:u1nR/EPcESfeI/szUZKdtJ0xRNbUoANCkoOuaOx1Y+c=
 github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
 github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
@@ -75,6 +77,7 @@ github.com/ugorji/go v1.2.7/go.mod h1:nF9osbDWLy6bDVv/Rtoh6QgnvNDpmCalQV5urGCCS6
 github.com/ugorji/go/codec v1.1.7/go.mod h1:Ax+UKWsSmolVDwsd+7N3ZtXu+yMGCf907BLYF3GoBXY=
 github.com/ugorji/go/codec v1.2.7 h1:YPXUKf7fYbp/y8xloBqZOw2qaVggbfwMlI8WM3wZUJ0=
 github.com/ugorji/go/codec v1.2.7/go.mod h1:WGN1fab3R1fzQlVQTkfxVtIBhWDRqOviHU95kRgeqEY=
+github.com/urfave/negroni v1.0.0/go.mod h1:Meg73S6kFm/4PpbYdq35yYWoCZ9mS/YSx+lKnmiohz4=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97 h1:/UOmuWzQfxxo9UtlXMwuQU8CMgg1eZXqTRwkSQJWKOI=

release.toml

@@ -0,0 +1,18 @@
+[Metadata]
+
+Author = "Matheus Politano"
+Release_file_version = "2.1"
+
+[Description]
+
+Notes = """
+This is the first Merge request
+"""
+
+
+[[Digest.Bugs]]
+Name = "Fix main bugs"
+Issue = 1
+Description = """
+
+"""

scripts/validate_release.go

@@ -0,0 +1,108 @@
+package main
+
+import (
+	"fmt"
+	"os"
+	"strings"
+
+	"github.com/pelletier/go-toml"
+)
+
+type Release struct {
+	Metadata struct {
+		Author             string `toml:"Author"`
+		ReleaseFileVersion string `toml:"Release_file_version"`
+	} `toml:"Metadata"`
+
+	Description struct {
+		Notes string `toml:"Notes"`
+	} `toml:"Description"`
+
+	Digest struct {
+		Features     []Section `toml:"Features"`
+		Improvements []Section `toml:"Improvements"`
+		Bugs         []Section `toml:"Bugs"`
+	} `toml:"Digest"`
+}
+
+type Section struct {
+	Name        string `toml:"Name"`
+	Issue       int    `toml:"Issue"`
+	Description string `toml:"Description"`
+}
+
+func validateRelease(filePath string) error {
+	content, err := os.ReadFile(filePath)
+	if err != nil {
+		return fmt.Errorf("failed to read file: %v", err)
+	}
+
+	// Basic format check
+	if !strings.HasPrefix(string(content), "[Metadata]") {
+		return fmt.Errorf("file must start with [Metadata] section")
+	}
+
+	// Parse TOML
+	var release Release
+	err = toml.Unmarshal(content, &release)
+	if err != nil {
+		return fmt.Errorf("invalid TOML format: %v", err)
+	}
+
+	// Check required fields in Metadata
+	if release.Metadata.Author == "" || release.Metadata.ReleaseFileVersion == "" {
+		return fmt.Errorf("missing required fields in Metadata")
+	}
+
+	// Check Notes in Description
+	if release.Description.Notes == "" {
+		return fmt.Errorf("Notes in Description must not be empty")
+	}
+
+	// Check Digest sections
+	if len(release.Digest.Features) == 0 && len(release.Digest.Improvements) == 0 && len(release.Digest.Bugs) == 0 {
+		return fmt.Errorf("at least one Digest section (Features, Improvements, Bugs) must be provided")
+	}
+
+	// Ensure every entry in Digest has required fields
+	validateSection := func(sections []Section) error {
+		for _, section := range sections {
+			if section.Name == "" || section.Issue == 0 || section.Description == "" {
+				return fmt.Errorf("Digest entries must have Name, Issue, and Description filled out")
+			}
+		}
+		return nil
+	}
+
+	if err := validateSection(release.Digest.Features); err != nil {
+		return err
+	}
+	if err := validateSection(release.Digest.Improvements); err != nil {
+		return err
+	}
+	if err := validateSection(release.Digest.Bugs); err != nil {
+		return err
+	}
+
+	return nil
+}
+
+func main() {
+	releaseFile := "./release.toml"
+	// Check if file exists
+
+	fmt.Println("Checking if release file exists")
+	if _, err := os.Stat(releaseFile); os.IsNotExist(err) {
+		fmt.Println("release.toml file not found")
+		os.Exit(1)
+	}
+
+	// Validate file
+	fmt.Println("Validating release file")
+	err := validateRelease(releaseFile)
+	if err != nil {
+		fmt.Printf("Validation failed: %v\n", err)
+		os.Exit(1)
+	}
+
+}