Skip to content

Commit

Permalink
kdb: Avoid using dbg_io_ops until it is initialized
Browse files Browse the repository at this point in the history
This fixes a bug with setting a breakpoint during kdb initialization
(from kdb_cmds).  Any call to kdb_printf() before the initialization
of the kgdboc serial console driver (which happens much later during
bootup than kdb_init), results in kernel panic due to the use of
dbg_io_ops before it is initialized.

Signed-off-by: Tim Bird <tim.bird@am.sony.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
  • Loading branch information
Tim Bird authored and jwessel committed Mar 22, 2012
1 parent bec4d62 commit b8adde8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/debug/kdb/kdb_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ int vkdb_printf(const char *fmt, va_list ap)
if (!dbg_kdb_mode && kgdb_connected) {
gdbstub_msg_write(kdb_buffer, retlen);
} else {
if (!dbg_io_ops->is_console) {
if (dbg_io_ops && !dbg_io_ops->is_console) {
len = strlen(kdb_buffer);
cp = kdb_buffer;
while (len--) {
Expand Down

0 comments on commit b8adde8

Please sign in to comment.