Skip to content

Commit

Permalink
genirq: Fix wrong bit operation
Browse files Browse the repository at this point in the history
(!msk & 0x01) should be !(msk & 0x01)

Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
Link: http://lkml.kernel.org/r/1311229754-6003-1-git-send-email-jhbird.choi@samsung.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org
  • Loading branch information
jhbird.choi@samsung.com authored and KAGA-KOKO committed Jul 26, 2011
1 parent 02f8c6a commit 1dd75f9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/irq/generic-chip.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ void irq_setup_generic_chip(struct irq_chip_generic *gc, u32 msk,
gc->mask_cache = irq_reg_readl(gc->reg_base + ct->regs.mask);

for (i = gc->irq_base; msk; msk >>= 1, i++) {
if (!msk & 0x01)
if (!(msk & 0x01))
continue;

if (flags & IRQ_GC_INIT_NESTED_LOCK)
Expand Down Expand Up @@ -301,7 +301,7 @@ void irq_remove_generic_chip(struct irq_chip_generic *gc, u32 msk,
raw_spin_unlock(&gc_lock);

for (; msk; msk >>= 1, i++) {
if (!msk & 0x01)
if (!(msk & 0x01))
continue;

/* Remove handler first. That will mask the irq line */
Expand Down

0 comments on commit 1dd75f9

Please sign in to comment.