Skip to content

make delete missing cluster compatable#23

Merged
cbrady merged 2 commits intomainfrom
chris/sch-4922-fix-delete-missing-to-work-with-clusters
Oct 27, 2025
Merged

make delete missing cluster compatable#23
cbrady merged 2 commits intomainfrom
chris/sch-4922-fix-delete-missing-to-work-with-clusters

Conversation

@cbrady
Copy link
Collaborator

@cbrady cbrady commented Oct 22, 2025

bulk deleting missing keys was not reliable because bulk operations can not be called cross node in Redis clusters and the keys could be in different nodes.

@cbrady cbrady self-assigned this Oct 22, 2025
@cbrady cbrady requested a review from a team as a code owner October 22, 2025 19:38
}

// loadCompaniesSequential loads companies sequentially (fallback method)
func (al *AsyncInitialLoader) loadCompaniesSequential(ctx context.Context) error {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and loadUsersSequentially were unused.

@cbrady cbrady force-pushed the chris/sch-4922-fix-delete-missing-to-work-with-clusters branch from d306a08 to 3258db4 Compare October 24, 2025 16:43
@cbrady cbrady merged commit bdb4df0 into main Oct 27, 2025
2 checks passed
@cbrady cbrady deleted the chris/sch-4922-fix-delete-missing-to-work-with-clusters branch October 27, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants