Merged
Conversation
dontlaugh
reviewed
Oct 1, 2025
dontlaugh
previously requested changes
Oct 1, 2025
cbrady
force-pushed
the
chris/sch-4649-fix-issue-with-marshaling-flags-from-datastream
branch
from
ca02326 to
1553990
Compare
cbrady
force-pushed
the
chris/sch-4649-fix-issue-with-marshaling-flags-from-datastream
branch
from
1553990 to
cb19021
Compare
dontlaugh
reviewed
Oct 1, 2025
Comment on lines
+212
to
+216
| logger := NewSchematicLogger() | ||
| mockCompanyCache := NewMockBatchCacheProvider[*rulesengine.Company]() | ||
| mockUserCache := NewMockBatchCacheProvider[*rulesengine.User]() | ||
| mockFlagCache := NewMockCacheProvider[*rulesengine.Flag]() | ||
| config := createTestAsyncConfig() |
dontlaugh
reviewed
Oct 1, 2025
| } | ||
|
|
||
| // Wait for batch processing | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
I am not going to block this PR, but we could perhaps invert this by giving the mock service a channel
assert.NoError(t, <-mockUserCache.Done()) // done or timeout
dontlaugh
reviewed
Oct 1, 2025
|
|
||
| // Use very short timeout to test timeout scenario | ||
| shutdownCtx, cancel := context.WithTimeout(context.Background(), 10*time.Millisecond) | ||
| defer cancel() |
There was a problem hiding this comment.
Probably doesn't matter, but I think t.Cleanup is a better choice here.
dontlaugh
reviewed
Oct 1, 2025
| ) | ||
|
|
||
| // MockBatchCacheProvider extends MockCacheProvider with batch operations | ||
| type MockBatchCacheProvider[T any] struct { |
There was a problem hiding this comment.
Could we add timeout/cancelation machinery to this struct (and its constructor)?
bpapillon
approved these changes
Oct 1, 2025
cbrady
deleted the
chris/sch-4649-fix-issue-with-marshaling-flags-from-datastream
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.