Conversation
dontlaugh
reviewed
Mar 27, 2025
| /// <summary> | ||
| /// Header containing the webhook signature. | ||
| /// </summary> | ||
| public const string WebhookSignatureHeader = "X-Schematic-Webhook-Signature"; |
There was a problem hiding this comment.
I can't remember if CSharp allows you do put constants outside a class, but these might be better suited at namespace scope.
There was a problem hiding this comment.
Thinking more about this - and this goes for every official SDK - if we want to gather all the valid headers globally, we can probably import and re-export them in a dedicated namespace. Not a blocker here.
dontlaugh
reviewed
Mar 27, 2025
dontlaugh
requested changes
Mar 27, 2025
dontlaugh
left a comment
dontlaugh
left a comment
There was a problem hiding this comment.
Just one missing test case. Otherwise looks good. The test server is a nice touch.
dontlaugh
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.